chore: improve playground #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncenter
changed the title
<title> with theme name, improved styling
antfu
reviewed
Jan 29, 2024
playground/src/App.vue
Outdated
| import { themes } from '../../packages/tm-themes/index' | ||
| import { grammars } from '../../packages/tm-grammars/index' | ||
|
|
||
| useDark() | ||
|
|
||
| const theme = useStorage('tm-theme', 'vitest-dark') | ||
| const theme = useStorage('tm-theme', themes.find(t => t.name === 'vitest-dark') as ThemeInfo) |
There was a problem hiding this comment.
Suggested change
| const theme = useStorage('tm-theme', themes.find(t => t.name === 'vitest-dark') as ThemeInfo) | |
| const theme = useStorage('tm-theme', 'vitesse-dark') |
I made a typo here - by why do we need to store the theme object?
There was a problem hiding this comment.
To store the displayName for the page's <title>. I wasn't sure how else to do it since I'm unfamiliar with Vue.
evoactivity
added a commit
to evoactivity/textmate-grammars-themes
that referenced
this pull request
Jan 29, 2024
* main: chore: improve playground (shikijs#19) feat: add fortran (free form) grammar (shikijs#18) chore: improve playground info display, close shikijs#20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code to update the
<title>element with the current selected theme name, and improves styling.