Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add terraform grammar #33

Merged
merged 2 commits into from
Feb 14, 2024
Merged

feat: add terraform grammar #33

merged 2 commits into from
Feb 14, 2024

Conversation

vinyl-umbrella
Copy link
Contributor

Added language support for tf and tfvars used in Terraform, an IaC tool.

image

Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for textmate-grammars-themes ready!

Name Link
🔨 Latest commit 44d32ed
🔍 Latest deploy log https://app.netlify.com/sites/textmate-grammars-themes/deploys/65ccd388b024c7000813d2d5
😎 Deploy Preview https://deploy-preview-33--textmate-grammars-themes.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antfu
Copy link
Member

antfu commented Feb 14, 2024

What's the difference between HCL and Terraform? According to GitHub Linguist, it seems to be an alias of HCL?
https://github.com/github-linguist/linguist/blob/559a6426942abcae16b6d6b328147476432bf6cb/lib/linguist/languages.yml#L2654-L2670

@vinyl-umbrella
Copy link
Contributor Author

hcl and tf have slightly different uses, but in a grammatical sense they may be almost identical.

I'm no expert on *tmGrammar.json, but I checked the diff between hcl tmGrammar and terraform tmGrammar and found that there were some differences. So I treated them as different syntaxes.

If hcl, tf, and tfvars should be treated as the same syntax, I will fix this PR.

Thank you for review!

@antfu antfu merged commit fd79c41 into shikijs:main Feb 14, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants