Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thunar: Selected sidepane item when disabled should not stand out #348

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andreldm
Copy link
Contributor

When Thunar is not focused, the selected item in the sidepane is not grayed out, this is not really perceptible because only the label text remains black-ish, when symbolic icons (new feature, behind a hidden toggle) are used this glitch is more prominent.

This PR fixes only Thunar's sidepane, 1. because I couldn't make this a generic style adjustment in _commons.scss, 2. because I'm afraid it could cause regressions.

The icon theme used in the screenshots below is Papirus.

Before After
Regular Icons 16px image image
Regular Icons 32px image image
Symbolic Icons 16px image image
Symbolic Icons 32px image image

dark/gtk-3.0/_xfce.scss Show resolved Hide resolved
dark/gtk-3.0/_xfce.scss Show resolved Hide resolved
light/gtk-3.0/_xfce.scss Show resolved Hide resolved
light/gtk-3.0/_xfce.scss Show resolved Hide resolved
@andreldm
Copy link
Contributor Author

@bluesabre @ochosi can I drag you guys back to review this PR? 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants