Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status: Make symbolic audio icons bigger #388

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

newhoa
Copy link
Contributor

@newhoa newhoa commented Jul 22, 2023

New symbolic audio icons to make size of status / systray icons more consistent.
Also uses the new strikethrough style for muted and blocking.

Addresses part of #152

Current:
audio-sym-current

audio-sym-current-notify

Proposed:
audio-sym-prop1

audio-sym-prop1-notify


This PR uses this style for audio-volume-muted-symbolic and audio-volume-muted-blocking-symbolic:
audio-sym-prop1-muted

Here is an alternative, more like what upstream uses. When you go from audo low to mute, the icon "jumps" more (the speaker icon goes from left to center) and to me is a little less legible (the strikethrough sort of blocks what is behind it). But, it is cleaner looking:
audio-sym-prop1-muted-alt

Up to you on what looks better, I don't have a strong feeling either way. Here are the SVGs if you want to try them in-use.
audio-volume-muted-symbolic
audio-volume-muted-blocking-symbolic

New symbolic audio icons to make size of status / systray icons more consistent.
Also uses the new strikethrough style for muted and blocking.

Addresses part of shimmerproject#152
@ochosi
Copy link
Member

ochosi commented Oct 10, 2023

Same question as for the wifi icon - how does upstream solve this problem?

@newhoa
Copy link
Contributor Author

newhoa commented Oct 10, 2023

Upstream went with the rounded speaker a bit ago, but it changed the way the icons are positioned and the bars appear. You can see between their high and low that the icon is always centered, with one of the "loudness bars" removed in each lowered state. So the speaker shifts from the middle at low or off to the far left when full, with the bars moving position each time as well. In the Xfce panel and a lot of apps, at least, it meant the icon shifted with every volume state which didn't feel very smooth.

So this was kind of a compromise between upstream and our current one, while also trying to fix the size consistency problems in #152.

Fixing the size consistency meant making the speaker bigger. I think it makes the speaker easier to see and looks a little more balanced on each side or overall and fits in better with the others with this look... but it did leave less room for the bars. So I did need to reduce the curviness a little, not sure if I did that well enough or if they look quite as clear. That was the hard part on this that I don't know if I got good enough. Any feedback would be appreciated!

Copy link
Member

@ochosi ochosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, wasn't aware of the upstream speaker changes!
These small icons are always a bit of a compromise, I think you did a great job and keeping the thing centered is certainly a win!

@ochosi ochosi merged commit 97a85de into shimmerproject:master Oct 14, 2023
1 check passed
@newhoa newhoa deleted the audio-symbolic-icon-larger branch March 11, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants