Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old Xfce icons #397

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

newhoa
Copy link
Contributor

@newhoa newhoa commented Sep 8, 2023

Thought enough time has passed that this cleanup would be okay. Nearly four years by the time the next release comes around, and thought with an LTS coming up this would be a good time to switch over.

If this and the other App PRs are okay, please merge the others first, this one may need conflict resolutions for rebase after those.

Sorry for the huge PR, it required a looot of renaming and resymlinking.


Remove old Xfce action, panel, and status icons that are no longer used. Most of these have not been used since Xfce 4.12 or before.

For apps, drop Xfce 4.14 and older icon names in favor of the Xfce 4.16 and above rDNS named icons.

Remove old Xfce action, panel, and status icons that are no longer used.
Most of these have not been used since Xfce 4.12 or before.

For apps, drop Xfce 4.14 and older icon names in favor
of the Xfce 4.16 and above rDNS named icons.
@newhoa
Copy link
Contributor Author

newhoa commented Oct 9, 2023

@ochosi Thanks for all the reviews/merges! I rebased and resolved the conflicts for these remaining PRs so they should be good for review whenever you get more time. Thanks again!

Copy link
Member

@ochosi ochosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally like supporting older Xfce versions, but I guess with the amount of other cleanups we're breaking older systems/setups anyway. Plus, Xfce hasn't really increased much in resource usage since 4.14, so everyone can upgrade...

Thanks for doing the cleanup work!

@ochosi ochosi merged commit 2d4b8c1 into shimmerproject:master Oct 10, 2023
1 check passed
@newhoa newhoa deleted the remove-xfce-pre-416-new branch March 11, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants