Remove old Xfce icons #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove old Xfce action, panel, and status icons that are no longer used. Most of these have not been used since Xfce 4.12 or before. For apps, drop Xfce 4.14 and older icon names in favor of the Xfce 4.16 and above rDNS named icons.
newhoa
force-pushed
the
remove-xfce-pre-416-new
branch
from
daa950b
to
80075b6
Compare
|
@ochosi Thanks for all the reviews/merges! I rebased and resolved the conflicts for these remaining PRs so they should be good for review whenever you get more time. Thanks again! |
ochosi
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
I generally like supporting older Xfce versions, but I guess with the amount of other cleanups we're breaking older systems/setups anyway. Plus, Xfce hasn't really increased much in resource usage since 4.14, so everyone can upgrade...
Thanks for doing the cleanup work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought enough time has passed that this cleanup would be okay. Nearly four years by the time the next release comes around, and thought with an LTS coming up this would be a good time to switch over.
If this and the other App PRs are okay, please merge the others first, this one may need conflict resolutions for rebase after those.
Sorry for the huge PR, it required a looot of renaming and resymlinking.
Remove old Xfce action, panel, and status icons that are no longer used. Most of these have not been used since Xfce 4.12 or before.
For apps, drop Xfce 4.14 and older icon names in favor of the Xfce 4.16 and above rDNS named icons.