Ensure UTF8 encoding

[dgilm]

Avoid future problems with database fields encoded with latin1 and other codifications. This fixes a livestatus error (shinken-monitoring/mod-livestatus#33) creating a livestatus response with fields imported with this module encoded as latin1.

[Seb-Solon]

Thanks!

Same suggestion for this module about tests :)

[naparuba]

Hi,

I'm not ok with this patch. It import chardet that is not a default module. It add a new dep for a very specific case. So it should be at least optional and called only if need, and if possible avoid even with a new module parameter (like let the user set the charset if it's not utf8 for example).

[naparuba]

PB here :)

[dgilm]

I didn't know that chardet isn't a default module although is installed in all my systems without extra actions. Sorry about that.

In that case @naparuba, I should have check if chardet is installed before using it. Check out the following patch:
dgilm@a36ea5a

I can prepare a new pull request if you want.

[naparuba]

Thanks :)

On Mon, Sep 29, 2014 at 1:28 PM, David Gil [email protected] wrote:

I didn't know that chardet isn't a default module although is installed in
all my systems without doing anything. Sorry about that.

In that case @naparuba https://github.com/naparuba, I should have check
if chardet is installed before using it. Checkout the following patch:
dgilm/mod-import-mysql@a36ea5a
dgilm@a36ea5a

I can prepare a new pull request if you want.

—
Reply to this email directly or view it on GitHub
#7 (comment)
.