Update mapping.py #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using this module, I get the following to STDERR during shinken config check: ''' /var/lib/shinken/modules/livestatus/mapping.py:45: DeprecationWarning: shinken.schedulerlink is deprecated module path ; schedulerlink must now be imported from shinken.objects.schedulerlink ; please update your code accordingly from shinken.schedulerlink import SchedulerLink /var/lib/shinken/modules/livestatus/mapping.py:46: DeprecationWarning: shinken.reactionnerlink is deprecated module path ; reactionnerlink must now be imported from shinken.objects.reactionnerlink ; please update your code accordingly from shinken.reactionnerlink import ReactionnerLink /var/lib/shinken/modules/livestatus/mapping.py:47: DeprecationWarning: shinken.brokerlink is deprecated module path ; brokerlink must now be imported from shinken.objects.brokerlink ; please update your code accordingly from shinken.brokerlink import BrokerLink /var/lib/shinken/modules/livestatus/mapping.py:48: DeprecationWarning: shinken.receiverlink is deprecated module path ; receiverlink must now be imported from shinken.objects.receiverlink ; please update your code accordingly from shinken.receiverlink import ReceiverLink /var/lib/shinken/modules/livestatus/mapping.py:49: DeprecationWarning: shinken.pollerlink is deprecated module path ; pollerlink must now be imported from shinken.objects.pollerlink ; please update your code accordingly from shinken.pollerlink import PollerLink ''' Adding ".objects" to lines 45-49 in the mapping.py fixes these errors.
|
hi @ChrisHeerschap but, for now, we keep these imports as it.. So that livestatus can continue to just work with previous Shinken version when this refactorization occured. but I keep the PR open until .. until we can drop previous shinken versions (< 2.4) support ; which will be sooner than later ;) |
|
NB: it's not errors, it's warnings ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this module, I get the following to STDERR during shinken config check:
Adding ".objects" to lines 45-49 in the mapping.py fixes these errors.