Fixed omission of warn, grit, min or max from graphs if set to 0 #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
String version of Metric does not include min or max values, even if they were present in the string passed to the constructor. String version of Metric does not include values for warn, crit, min, max if they were specified as 0. This happens because their inclusion in the string representation of Metric was conditional on their boolean value (which is false for 0). Changed to check for None instead. String version of Metric did not collapse None values into empty semi-colon delimited sections, causing input of ;;1 to result in ;1 on conversion to string.
When to uom is % min and max were always forced to 0. This causes graphs to always have 0 and 100 for min and max, even if other values were supplied. This is changed to only force the default values if no other values had been set. In addition, when converting a Metric to a string, those same min and max values were always included. If they are actually 0 and 100 that is not necessary, and they are now left out, but only if not explicitly specified on input. These changes allow control over the appearance of min and max lines in graphs, regardless of their desired values. If the value is specified, even when equal to a default, they will be output and thus graphed. If defaults were generated, they will not be graphed. This leaves the semantics of the perfdata unchanged.
Fix handling of min and max values for percentages
|
Travis CI build failed due to unavailability of a/the test port. This seems a problem in the build system that I cannot correct as part of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String version of
Metricdoes not include min or max values, even if they were present in the string passed to the constructor.String version of
Metricdoes not include values for warn, crit, min, or max if they were specified with value0. This happens because their inclusion in the string representation ofMetricwas conditional on their boolean-ish value (which isfalsefor0). Changed to check forNoneinstead.String version of Metric did not collapse None values into empty semi-colon delimited sections, causing input of
;;1to result in;1on conversion to string. Combined with above to remove collapsedNonevalues from the end as well.