Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mod-livestatus issue #74 #1882

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ianling
Copy link

@ianling ianling commented Dec 7, 2016

shinken-monitoring/mod-livestatus#74

mod-livestatus was unable to retrieve a contact's host notification period and service notification period, and consequently, was also unable to determine if a timestamp fell within those periods.

This fix uncomments the two linkify calls in contact.py, which allows livestatus to get the notification periods from the Contact object.

mod-livestatus was unable to retrieve a contact's host notification period and service notification period, and consequently, was also unable to determine if a timestamp fell within those periods.

This fix uncomments the two linkify calls in contact.py, which allows livestatus to get the notification periods from the Contact object.
@ianling
Copy link
Author

ianling commented Dec 7, 2016

Not sure why Travis is failing to build this; I'm running this change in production without any issues.

@geektophe
Copy link
Collaborator

Those calls have been commented by @naparuba in 9ae1db6, I don't clearly know why. But it seems there was a reason. I'll try to find a corresponding ticket.

@geektophe
Copy link
Collaborator

I don't see any ticket about this issue. @naparuba do you remember why it has been commented ?

@naparuba
Copy link
Contributor

That's because theses objects are now used not by the contact itself but by the inner notification way. So the problem is to let link just for livestatus, because the framework do not need it.

The good solution should be to find the inner notification in livestatus and get the value from it, directly in the livestatus module, so not all the framework will have theses properties linked with objects for just one module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants