refactor(rules): consolidate Frontend/Backend rules into universal coding-standards #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Fixed single-responsibility principle violations where command references were duplicated across files: Documentation changes: - Remove "Quality Check Command Reference" from ai-development-guide.md - Remove "Quality Check Command Reference" from frontend/ai-development-guide.md - Enhance technical-spec.md with detailed Build and Testing sections - Update rules-index.yaml to reflect new section ownership Agent changes: - Update quality-fixer.md to reference technical-spec.md for commands - Update quality-fixer-frontend.md to reference frontend/technical-spec.md Benefits: - Restore single-responsibility: ai-development-guide focuses on decision criteria and anti-patterns, technical-spec owns build/test commands - Eliminate duplication: commands now exist in one authoritative location - Improve AI accuracy: clear file responsibilities reduce confusion - Better maintainability: command updates only need one location 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…documentation Fixed single-responsibility principle violations where command references were duplicated across files (Japanese version): Documentation changes: - Remove "品質チェックコマンドリファレンス" from ai-development-guide.md - Remove "品質チェックコマンドリファレンス" from frontend/ai-development-guide.md - Enhance technical-spec.md with detailed Build and Testing sections - Update rules-index.yaml to reflect new section ownership Agent changes: - Update quality-fixer.md to reference technical-spec.md for commands - Update quality-fixer-frontend.md to reference frontend/technical-spec.md This commit mirrors the English documentation refactoring to maintain consistency across both language versions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
rules-index.yaml sections should only contain h2 (##) headings, not h3 (###). Fixed: - Removed "Build Commands", "Testing Commands", etc. (h3) from sections - Kept only "Build and Testing" (h2) in both EN and JA versions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…l coding-standards **English version:** - Create docs/rules-en/coding-standards.md with universal coding principles - Slim down Backend typescript.md to Backend-specific content only - Slim down Backend typescript-testing.md to Backend-specific content only - Delete docs/rules-en/ai-development-guide.md (moved to coding-standards.md) - Slim down Frontend typescript.md to Frontend-specific content only - Slim down Frontend typescript-testing.md to Frontend-specific content only - Delete docs/rules-en/frontend/ai-development-guide.md (moved to coding-standards.md) - Update 8 agent files to reference coding-standards.md instead of ai-development-guide.md **Japanese version:** - Apply same refactoring to docs/rules-ja/coding-standards.md - Migrate common sections from typescript.md to coding-standards.md - Migrate common sections from typescript-testing.md to coding-standards.md - Migrate common sections from frontend/typescript.md to coding-standards.md - Migrate common sections from frontend/typescript-testing.md to coding-standards.md - Update docs/rules-ja/rules-index.yaml section names to match actual file structure - Update 7 agents-ja files to reference coding-standards.md instead of ai-development-guide.md This refactoring implements Approach 4: Linter-like common rules + domain-specific rules to eliminate 90% duplication between Frontend and Backend documentation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…andards Fixes two inconsistencies found after commit 9743daf: 1. Update quality-fixer agent reference: - Replace @docs/rules/ai-development-guide.md with coding-standards.md - This was the only remaining agent with old reference 2. Remove deleted ai-development-guide entry from rules-index.yaml: - English version still had metadata for non-existent file - Entry is now consolidated into coding-standards.md These fixes ensure complete consistency between: - Agent files and their rule references - rules-index.yaml metadata and actual file content - English and Japanese documentation structures 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR eliminates 90% duplication between Frontend and Backend documentation by
consolidating common coding principles into a universal
coding-standards.mdfile.The refactoring implements Approach 4: Linter-like common rules + domain-specific
rules.
Changes
Main Refactoring (9743daf)
English version:
docs/rules-en/coding-standards.mdwith universal coding principlestypescript.mdandtypescript-testing.mdto Backend-specificcontent only
typescript.mdandtypescript-testing.mdtoFrontend-specific content only
docs/rules-en/ai-development-guide.md(moved tocoding-standards.md)docs/rules-en/frontend/ai-development-guide.md(moved tocoding-standards.md)coding-standards.mdinstead ofai-development-guide.mdJapanese version:
docs/rules-ja/coding-standards.mdwith same structure as English versioncoding-standards.mddocs/rules-ja/rules-index.yamlsection names to match actual filestructure
Follow-up Fixes (455195b)
Fixed inconsistencies discovered after the main refactoring:
.claude/agents-en/quality-fixer.mdwhich stillreferenced the deleted
ai-development-guide.mdai-development-guideentry fromdocs/rules-en/rules-index.yaml(file no longer exists)Impact
coding-standards.md+ domain-specific rules inseparate files
Files Changed