Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ruby & Rails versions on CI and fix Sequel spec failures #617

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

shioyama
Copy link
Owner

@shioyama shioyama commented May 27, 2023

Overdue cleanup.

Sequel

  • Fix breaking test: The internal equality operator seems to have changed. Comparing SQL should be close enough.

ActiveRecord

  • remove all code supporting unsupported versions of Rails (< 6.1)
  • add Rails 7.1 to builds
  • fix edge failures related to serialize method signature

Ruby

  • remove all support for rubies < 3.0
  • skip multi-thread test on Ruby 3.2+ which is failing for mysterious reasons...

The internal equality operator seems to have changed. Comparing SQL
should be close enough.
@shioyama shioyama force-pushed the fix_sequel_failures branch 2 times, most recently from 31addf0 to b4ef59c Compare March 20, 2024 07:16
@shioyama shioyama changed the title Fix Sequel spec failures Update Ruby & Rails versions on CI and fix Sequel spec failures Mar 20, 2024
I don't know why this has started failing, but I'll let this go for now
so we can get back to green on master.
@shioyama shioyama merged commit 734af03 into master Mar 20, 2024
55 checks passed
@shioyama shioyama deleted the fix_sequel_failures branch March 20, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant