Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate SqlWalker deprecation trigger in Doctrine 3.3.0 #51

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

janedbal
Copy link
Member

Resolves #50

@janedbal janedbal merged commit dc1c787 into master Oct 18, 2024
8 checks passed
@janedbal janedbal deleted the doctrine-3-3-0-fix branch October 18, 2024 10:42
@hellomedia
Copy link

Your solution did not work in my symfony project.

Using $this->walkSelectStatement($AST) generates the LIMIT 2 times for me.

The deprecation message is not clear about this, but reading the migration path below, I think that instead of extending SqlWalker, they want users to now extend SqlOutputWalker which includes the proper getFinalizer().

BC/migration path
The solution is to have a new subclass SqlOutputWalker. By moving to and extending this new class, users indicate that they are aware of the necessary changes and have removed the limit/offset parts from their own SQL generation. Of course, users would be free to return their own SqlFinalizer implementations in case they need special offset/limit handling code.

@janedbal
Copy link
Member Author

@hellomedia Thank you, should be fixed in 2.0.2.


Note: issues are better for bug reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ORM deprecation
2 participants