Ranger Modernization & Tweaks #3313
Conversation
github-actions
bot
added
Map Change
|
mods can we merge this guy |
|
Hihi! Some stuff. Some copied from discord, some not.
|
| @@ -458,5 +341,5 @@ | |||
| /obj/item/disk/holodisk/lp/aid/guard = 1, | |||
| ) | |||
|
|
|||
| lootcount = 2 | |||
| lootcount = 4 | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Sadhorizon <[email protected]> Signed-off-by: fighterslam <[email protected]>
…into RangerRework
|
Can you replace the Lieutenant's duster with a Vigilitas HoS coat? As the guy in charge, it fits, and it's better to have him in Vigilitas gear than an indie duster. |
|
There is not a single dresser on the entire ship. Those are good to map in generally. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
_maps/configs/nanotrasen_ranger.json
Outdated
| @@ -1,24 +1,23 @@ | |||
| { | |||
| "$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json", | |||
| "prefix": "VISV", | |||
| "map_name": "Ranger-class Aid Vessel", | |||
| "faction": "/datum/faction/nt", | |||
There was a problem hiding this comment.
"faction": "/datum/faction/nt/vigilitas",
There was a problem hiding this comment.
I should probably have this tested for..
There was a problem hiding this comment.
To start, this is a ship that's been through a lot of iteration and testing. It functions well, and fits well enough as a remap for the Ranger. Most of this review will boil down to fixing errors and design issues.
Minor Fixes
The Saber SMG in the armory is not actually an NT weapon on a technicality. It is technically Inteq due to being pathed under their weapon, and thus comes with an Inteq colored stock. How you fix this is mostly up to you, be it removing the stock or just changing the weapon.
There is a wall intercom in the suit storage holding the RIG suit. I'd reccomend moving it to the wall over the table so this doesn't happen. Also, the RIG suit itself has a spelling error in its description. It should be "A fully heat-resistant suit based on an early RIG hardsuit prototype."
The "Aid Mission Recruitment Drive" disk has the objective of "The LP will need to convince 4 independent vessels to switch to NTSV flight tags". Due to our rules on false-flagging and ship prefixes, this may need to be changed. If you already talked with someone about this and got a pass for it, let me know and we can discuss it.
Similarly, "Combat Mission Blood Red" may need some changes to discourage players from blindly attempting to rob a syndicate ship. Very few syndicate ships even have a Blood-Red, so you may want to change this to acquiring a Rusted-Red which can be found in ruins or from Ramzi pirates.
Design Gripes
If you have a case for anything I bring up here, feel free to discuss it with me.
Filing cabinet on the table with the medkits looks strange. I would remove it or replace it with a wall locker for the medical kits. I don't see what the medical specialist would use this for, given that they have no paper and pen to use within reach of it.
Air supply pump should start active so that the airlocks can be used. I've seen a few people forget to turn their distro supply pump on and wonder why their airlocks aren't working.
Firelocks underneath an external airlock can interfere with them being used, as they will always close when the airlock opens to space. The firelocks in the hallway are more than enough to stop decompression if it breaches.
I'd suggest adding a few fire extinguisher cabinets in the engine nacelles or in the hallways near them. The full-sized lockers are good, but it feels strange for the only place on the ship to have a fire extinguisher cabinet be the operating room.
The decal and the holopad are off-center from eachother...
Bridge stairs have decals on them. Looks a bit strange.
Lastly and most importantly, What the Hell is up with the sheer volume of handrails on this ship? The ones on the walls are fine, but the ones on the railings and even a table are very odd looking. Just one or two per area on the walls is more than enough.
|
All requested changes have been made |
|
@Zevotech I think this should be ready for merge or at the very least to be testmerged again. I would like to get this PR out of limbo 🥺 |
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Updates the Ranger-Class, giving it facilities that feel better without significantly altering the balance.  Major changes: Adds a Logistics Specialist to the ship's crew manifest, and enhances the Cargo Bay to accommodate for them. Now they have a desk, a bed, and a locker, all painted in N+S colors! The Cargo Bay now also requires ship access to be opened/closed. The ship is now a bit more focused on "disaster response" rather than being a generalist, and the tags have been updated to reflect this. I might do some more work on this in the future, to lean into the "ship that can fix both the crew and the ship" aspect. This also leaves the niche of Vigilitas Gunship open for when that's made. Re-paints the ship to be more in line with Vigilitas colors, and reflect NT Spaceworks' designs (titanium hulls/windows) & updates the prefix to VISV. Smaller changes: Adds access locks to the AI core/Comms (engineering access), the Ready Room (requires Ship Access now and a non-intern role), security office, and specialist quarters/rooms Adds a few internal windows - the Bridge now has a shutter-able window to the atrium, Security gets shutterable windows, and so does Medical. Updates the Air Cycler to be more secure and not have any exterior windows, keeping with the Ranger's "no external windows" theme. Moves the atmospherics equipment to the engine bays, replacing the equipment room with a proper ready-room for the LP Squad, and a small armory compartment. Also adds a 9mm Saber SMG to the armory. All of the LP hardsuits have been moved into this ready-room, except for the Lieutenant's. Enhances Medical by replacing the weird cell with a proper surgical compartment, and uses tinted windows to give the Medical Specialist's bedroom some privacy. Rearranges the Security Specialist's office by giving them a proper desk, a records console, and a camera monitor, aswell as a much more functional holding cell. Makes the AI core & Comms room much prettier (and more secure) Adjusts the location of the docking port so you no longer need to cross hyperspace Expands the bridge slightly & adds more shutters to the ship. Fixes the LP med-spec's hardsuit to be spaceproof again. Enhances the LT's living quarters. Upgrades the Ion Engines to the premium variant - currently, it has the same amount of thrusters as a Kilo, but is significantly heavier. As it'd require significant hull changes to add more thrusters, they've just been upgraded to make it more fitting for a proper response ship. Adds an air refilling system, so you don't have to depressurize your air supply in order to refill it. Replaces the "Emergency EVA" closets with Fragile Space Suit Storage Units, which are weaker than the previous EVA suits + spawns less supplies. Makes it so the LP Lieutenant spawns with the Vigilitas Security Coat rather than the standard NT one, and removes the indie officer stuff from their closet. Fixes the Medical Specialist's hardsuit to be spaceproof again. Adds GPSes to every specialist's locker, instead of just a few, and gives the AI Core a stationary computer GPS. Shoves a dresser into Cryo. Adds External Atmospherics control - you can now control the external atmospherics fittings and also have an ability to actually check the external atmosphere with sensors. Code for it's a bit jank but it works. Are we out of scope yet? Countless other small changes I've forgotten about as this expands. <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Makes the Ranger feel much better to play on - brings the crew together more, makes the areas feel a bit more usable, and helps the Ranger lean into a specialization, rather than being Yet Another NT Generalist. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: balance: Modernizes and slightly buffs the Ranger. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: fighterslam <[email protected]> Co-authored-by: Sadhorizon <[email protected]>
Ranger Modernization & Tweaks (shiptest-ss13#3313)
About The Pull Request
Updates the Ranger-Class, giving it facilities that feel better without significantly altering the balance.
Major changes:
Adds a Logistics Specialist to the ship's crew manifest, and enhances the Cargo Bay to accommodate for them. Now they have a desk, a bed, and a locker, all painted in N+S colors! The Cargo Bay now also requires ship access to be opened/closed.
The ship is now a bit more focused on "disaster response" rather than being a generalist, and the tags have been updated to reflect this. I might do some more work on this in the future, to lean into the "ship that can fix both the crew and the ship" aspect. This also leaves the niche of Vigilitas Gunship open for when that's made.
Re-paints the ship to be more in line with Vigilitas colors, and reflect NT Spaceworks' designs (titanium hulls/windows) & updates the prefix to VISV.
Smaller changes:
Adds access locks to the AI core/Comms (engineering access), the Ready Room (requires Ship Access now and a non-intern role), security office, and specialist quarters/rooms
Adds a few internal windows - the Bridge now has a shutter-able window to the atrium, Security gets shutterable windows, and so does Medical.
Updates the Air Cycler to be more secure and not have any exterior windows, keeping with the Ranger's "no external windows" theme.
Moves the atmospherics equipment to the engine bays, replacing the equipment room with a proper ready-room for the LP Squad, and a small armory compartment. Also adds a 9mm Saber SMG to the armory. All of the LP hardsuits have been moved into this ready-room, except for the Lieutenant's.
Enhances Medical by replacing the weird cell with a proper surgical compartment, and uses tinted windows to give the Medical Specialist's bedroom some privacy.
Rearranges the Security Specialist's office by giving them a proper desk, a records console, and a camera monitor, aswell as a much more functional holding cell.
Makes the AI core & Comms room much prettier (and more secure)
Adjusts the location of the docking port so you no longer need to cross hyperspace
Expands the bridge slightly & adds more shutters to the ship.
Fixes the LP med-spec's hardsuit to be spaceproof again.
Enhances the LT's living quarters.
Upgrades the Ion Engines to the premium variant - currently, it has the same amount of thrusters as a Kilo, but is significantly heavier. As it'd require significant hull changes to add more thrusters, they've just been upgraded to make it more fitting for a proper response ship.
Adds an air refilling system, so you don't have to depressurize your air supply in order to refill it.
Replaces the "Emergency EVA" closets with Fragile Space Suit Storage Units, which are weaker than the previous EVA suits + spawns less supplies.
Makes it so the LP Lieutenant spawns with the Vigilitas Security Coat rather than the standard NT one, and removes the indie officer stuff from their closet.
Fixes the Medical Specialist's hardsuit to be spaceproof again.
Adds GPSes to every specialist's locker, instead of just a few, and gives the AI Core a stationary computer GPS.
Shoves a dresser into Cryo.
Adds External Atmospherics control - you can now control the external atmospherics fittings and also have an ability to actually check the external atmosphere with sensors. Code for it's a bit jank but it works. Are we out of scope yet?
Countless other small changes I've forgotten about as this expands.
Why It's Good For The Game
Makes the Ranger feel much better to play on - brings the crew together more, makes the areas feel a bit more usable, and helps the Ranger lean into a specialization, rather than being Yet Another NT Generalist.
Changelog
🆑
balance: Modernizes and slightly buffs the Ranger.
/:cl: