Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anti-Radiation Foam #3366

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Conversation

Erikafox
Copy link
Contributor

@Erikafox Erikafox commented Sep 15, 2024

About The Pull Request

Buyable foam that destroys radiation emitters, and decontaminates objects very efficiently.

Why It's Good For The Game

Makes wasteplanet survival less of a hassle when prepared

Changelog

🆑 Erika Fox
add: Anti-Radiation Foam is now available at the outpost
/:cl:

@github-actions github-actions bot added DME Edit Code change Watch something violently break. labels Sep 15, 2024
@github-actions github-actions bot removed the DME Edit label Sep 15, 2024
@thgvr
Copy link
Member

thgvr commented Sep 16, 2024

I'm not sure if we use those invisible radiation sources anymore really, and regardless they were invisible so not sure how useful this will be

@FalloutFalcon
Copy link
Member

could easily be reworked as a general anti rad shield foam

@FalloutFalcon
Copy link
Member

just as in it still looks like it would be useful regardless of if we have those rad sources. i will properly review later, i skimmed

Copy link
Member

@FalloutFalcon FalloutFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, small enough to probally merged without test merge. Unless someone wants to run a wasteplanet only gimmick or something lol

@FalloutFalcon FalloutFalcon added this pull request to the merge queue Sep 30, 2024
Merged via the queue into shiptest-ss13:master with commit c8515f4 Sep 30, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Oct 6, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Buyable foam that destroys radiation emitters, and decontaminates
objects very efficiently.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Makes wasteplanet survival less of a hassle when prepared
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl: Erika Fox
add: Anti-Radiation Foam is now available at the outpost
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants