-
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inteq Gygax and Durand Paladin shield backlash. Fixes Durand shield blocking bullets from any direction. #3382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
DME Edit
Sprites
A bikeshed full of soulless bikes.
Code change
Watch something violently break.
labels
Sep 17, 2024
Co-authored-by: Theos <[email protected]> Signed-off-by: Gristlebee <[email protected]>
shiptest-server
pushed a commit
that referenced
this pull request
Oct 4, 2024
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Oct 6, 2024
…locking bullets from any direction. (shiptest-ss13#3382) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> Adds a new mech variant, the IRMG Basenji Gygax. Featuring a much more powerful overclock, capable of charging through walls and obstacles in short bursts of intense speed. ![image](https://github.com/user-attachments/assets/5daae4b1-2d9f-4f6f-8237-e861f0e44254) Implements the backlash function for the Paladin Durand's shield. Coming into contact with it will apply a nasty shock to any attackers. The modification however prevents it from blocking bullets or projectiles. Fixes the Durand shield being able to block bullets from any direction. The proc didnt have the right arguments, and was using the Durand itself as the projectile it was supposed to defend itself against. Inteq Gygax sprite done by Rye-Rice, modified from sprites by INFRARED_BARON ## Why It's Good For The Game <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> New mechs are neat, and implements an intended feature that was wanted for the Paladin. Bug fixes are good too I think ## Changelog :cl: Gristlebee, Rye-Rice, INFRARED_BARON add: Inteq Gygax and mech charges add: Paladin shield backlash fix: Durand shield blocking all projectiles imageadd: Inteq Gygax sprites /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: Gristlebee <[email protected]> Co-authored-by: Theos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adds a new mech variant, the IRMG Basenji Gygax. Featuring a much more powerful overclock, capable of charging through walls and obstacles in short bursts of intense speed.
Implements the backlash function for the Paladin Durand's shield. Coming into contact with it will apply a nasty shock to any attackers. The modification however prevents it from blocking bullets or projectiles.
Fixes the Durand shield being able to block bullets from any direction. The proc didnt have the right arguments, and was using the Durand itself as the projectile it was supposed to defend itself against.
Inteq Gygax sprite done by Rye-Rice, modified from sprites by INFRARED_BARON
Why It's Good For The Game
New mechs are neat, and implements an intended feature that was wanted for the Paladin. Bug fixes are good too I think
Changelog
🆑 Gristlebee, Rye-Rice, INFRARED_BARON
add: Inteq Gygax and mech charges
add: Paladin shield backlash
fix: Durand shield blocking all projectiles
imageadd: Inteq Gygax sprites
/:cl: