Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trickwine refactor to use status effects #3390

Closed

Conversation

FalloutFalcon
Copy link
Member

@FalloutFalcon FalloutFalcon commented Sep 19, 2024

About The Pull Request

A general cleanup of code and moving alot of stuff over to status_effect to allow for better choreographing trickwine effects
I started this in may and should probably finish this

Why It's Good For The Game

cleans up alot of ugly and bad code. you can now tell if someone is hopped up on a trickwine easier.

Changelog

🆑
add: You can tell when someone is under the affects of a trickwine easier
refactor: refactored alot of trickwine code
/:cl:

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Sep 19, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Code change Watch something violently break. label Sep 19, 2024
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Sep 19, 2024
@FalloutFalcon FalloutFalcon marked this pull request as ready for review September 20, 2024 12:59
@FalloutFalcon FalloutFalcon added the Test Merge Required They'll have to do it for free. label Sep 20, 2024
@FalloutFalcon FalloutFalcon marked this pull request as draft September 24, 2024 14:05
Copy link
Contributor

github-actions bot commented Oct 1, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Merge Conflict Use Git Hooks, you're welcome. Test Merge Required They'll have to do it for free.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant