-
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trickwine refactor to use status effects #3390
Closed
FalloutFalcon
wants to merge
15
commits into
shiptest-ss13:master
from
FalloutFalcon:trickwine-but-good
Closed
Trickwine refactor to use status effects #3390
FalloutFalcon
wants to merge
15
commits into
shiptest-ss13:master
from
FalloutFalcon:trickwine-but-good
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…to trickwine-but-good
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code change
Watch something violently break.
Merge Conflict
Use Git Hooks, you're welcome.
Test Merge Required
They'll have to do it for free.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
A general cleanup of code and moving alot of stuff over to status_effect to allow for better choreographing trickwine effects
I started this in may and should probably finish this
Why It's Good For The Game
cleans up alot of ugly and bad code. you can now tell if someone is hopped up on a trickwine easier.
Changelog
🆑
add: You can tell when someone is under the affects of a trickwine easier
refactor: refactored alot of trickwine code
/:cl: