Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Talos and Scarab maints. #3658

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Sadhorizon
Copy link
Contributor

@Sadhorizon Sadhorizon commented Oct 27, 2024

About The Pull Request

Talos:

  • Makes them more similar style-wise to the Scarab.
  • Un-spaces them.
  • Makes them less boring by adding Stuff.

obraz

Scarab:

  • Makes them less messy and broken.
  • Makes the airlock an actual airlock.
    StrongDMM-2024-10-27 17 55 02

Why It's Good For The Game

People seem to love the Scarab maint, while hating on the Talos one, so Talos is now more similar.

Scarab gets some stuff I missed during actual PR.

Changelog

🆑
tweak: Talos maints were remapped. They are also no longer spaced.
/:cl:

@Sadhorizon Sadhorizon requested a review from a team as a code owner October 27, 2024 12:08
@Sadhorizon Sadhorizon changed the title Changes to the Talos maints. Remaps the Talos maints. Oct 27, 2024
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Ship Ship successfully tested. labels Oct 27, 2024
@Apogee-dev
Copy link
Contributor

Apogee-dev commented Oct 27, 2024

Those iron brick walls need to be removed, that isn’t really ship construction material. There’s also quite a bit of rust for what is supposed to be a newer ship class in lore, and you tend to lump the rusty walls all together. Spread out the rust spots a bit in isolated single tiles and just use metal walls for the rest.

Wires and overall construction are too messy. It’s maints, sure, but this is also a Hardline ship, not Miskilamo, and new construction and that.

You also removed all AAC airlocks, either leading into maints or leading to space. You need at least one set, or the wing will gradually depressurize. Unless you want to run pipe all the way to the tips, that’ll be back in their original positions.

@Sadhorizon
Copy link
Contributor Author

Sadhorizon commented Oct 27, 2024

You also removed all AAC airlocks, either leading into maints or leading to space. You need at least one set, or the wing will gradually depressurize.

wdym by that? Wing isn't depressurized rn, and there most certainly were no space-leading airlocks in the first place.

@Apogee-dev
Copy link
Contributor

Apogee-dev commented Oct 27, 2024

You also removed all AAC airlocks, either leading into maints or leading to space. You need at least one set, or the wing will gradually depressurize.

wdym by that? Wing isn't depressurized rn, and there most certainly were no space-leading airlocks in the first place.

The docking ports at the nose of each wing didn’t have an AAC because the entire wing was depressurized in the past. The AACs instead separated the main part of the ship from maints. Since maints are pressurized now you need AACs on those docking ports regardless of whether or not the airlocks are locked- any airlock separating a pressurized area from a potentially depressurized one needs an AAC.

@Sadhorizon Sadhorizon changed the title Remaps the Talos maints. Updates Talos and Scarab maints. Oct 27, 2024
@Apogee-dev
Copy link
Contributor

Apogee-dev commented Oct 28, 2024

Ack, minor issue I missed the first time through. Offset the airlock on the Talos’s starboard docking port one tile south please- with the current design someone dragging a solid object can’t get through that airlock and could even get stuck if they walk down a tile.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Oct 29, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map Change Tile placing is hard. Thank you for your service. Ship Ship successfully tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants