Total Turret Refactor #3844
Open
Total Turret Refactor #3844
+1,319
−1,601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkSuckerberg
requested review from
FalloutFalcon and
a team
as code owners
github-actions
bot
added
Map Change
Erikafox
reviewed
Nov 27, 2024
| stun_projectile_sound = 'sound/weapons/laser.ogg' | ||
| faction = list("neutral","silicon","turret") | ||
|
|
||
| /obj/machinery/porta_turret/syndicate/pod |
There was a problem hiding this comment.
iirc this is used on the assault pod from nukies and can be cut
There was a problem hiding this comment.
nope, it's used on a few maps teehee
|
alt-click lock and unlock on turrets could use some feedback (bubble alert or to_chat) |
Shiptest_MokoshZeta2024-11-2716-22-04.mp4I'm not sure what's going on here but I don't think this is intended. |
|
retaliate firing needs to check for if the turret is nonfunctional |
|
|
|
oh right yeah you told me this teehee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Turret code was absolute garbage. This goes through and re-does practically all of it, plus adds some new goodies for good measure.
Adds my own half-baked "simple beam" system, for when performance is allegedly important and you don't care that they look ugly and only show up when you can see the source object.
Why It's Good For The Game
Not spending so much time processing JUST turrets is super nice. Plus giving players the ability to actually control their turrets more is nice.
Changelog
🆑
add: You can now set turrets to filter by faction, mob type, and a few more criteria including "dangerous only" as well as the ability to disable retaliation.
add: Turret retaliation is a lot more vengeful. Don't mess with them.
add: Turrets will now spend a short time targetting you, pointing a beam at you to indicate that they're doing so.
del: Turret covers, because they sucked.
fix: Turretcode is a LOT less laggy.
tweak: Turrets are now built like normal machines. The boards are currently not available (except through salvaging).
tweak: You can now access full turret settings from the turret control panel.
/:cl: