Skip to content
Verify

Conversion webhook #1688

Sign in to view logs

Conversion webhook

Conversion webhook #1688

Triggered via pull request August 15, 2023 09:48
@qu1queeequ1queee
synchronize #1302
qu1queee:qu1queee/conversion_webhook
Status Failure
Total duration 34s
Artifacts –

verify.yaml

on: pull_request
Verify
25s
Verify
Fit to window
Zoom out
Zoom in

Annotations

7 errors and 10 warnings
Verify: go/src/github.com/shipwright-io/build/pkg/apis/build/v1alpha1/clusterbuildstrategy_conversion.go#L18
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
Verify: go/src/github.com/shipwright-io/build/pkg/apis/build/v1alpha1/clusterbuildstrategy_conversion.go#L22
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
Verify: go/src/github.com/shipwright-io/build/pkg/apis/build/v1alpha1/buildstrategy_conversion.go#L18
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
Verify: go/src/github.com/shipwright-io/build/pkg/apis/build/v1beta1/build_conversion.go#L96
G601: Implicit memory aliasing in for loop. (gosec)
Verify: go/src/github.com/shipwright-io/build/pkg/webhook/conversion/conversion.go#L130
`enconding` is a misspelling of `encoding` (misspell)
Verify: go/src/github.com/shipwright-io/build/pkg/webhook/conversion/converter_test.go#L50
`accross` is a misspelling of `across` (misspell)
Verify
issues found
Verify: go/src/github.com/shipwright-io/build/pkg/apis/build/v1beta1/buildrun_conversion.go#L57
redefines-builtin-id: redefinition of the built-in function new (revive)
Verify: go/src/github.com/shipwright-io/build/pkg/apis/build/v1beta1/build_conversion.go#L19
var-naming: don't use ALL_CAPS in Go names; use CamelCase (revive)
Verify: go/src/github.com/shipwright-io/build/pkg/apis/build/v1beta1/buildrun_conversion.go#L186
redefines-builtin-id: redefinition of the built-in function new (revive)
Verify: go/src/github.com/shipwright-io/build/pkg/apis/build/v1beta1/build_conversion.go#L20
var-naming: don't use ALL_CAPS in Go names; use CamelCase (revive)
Verify: go/src/github.com/shipwright-io/build/pkg/apis/build/v1beta1/build_conversion.go#L163
receiver-naming: receiver name srcSpec should be consistent with previous receiver name dest for BuildSpec (revive)
Verify: go/src/github.com/shipwright-io/build/pkg/apis/build/v1beta1/build_conversion.go#L114
redefines-builtin-id: redefinition of the built-in function new (revive)
Verify: go/src/github.com/shipwright-io/build/pkg/webhook/conversion/conversion.go#L63
context-as-argument: context.Context should be the first parameter of a function (revive)
Verify: go/src/github.com/shipwright-io/build/pkg/webhook/conversion/conversion.go#L69
context-as-argument: context.Context should be the first parameter of a function (revive)
Verify: go/src/github.com/shipwright-io/build/pkg/webhook/conversion/conversion.go#L164
context-as-argument: context.Context should be the first parameter of a function (revive)
Verify: go/src/github.com/shipwright-io/build/pkg/webhook/conversion/converter.go#L19
var-naming: don't use ALL_CAPS in Go names; use CamelCase (revive)