Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Fix variable usage in message.

Co-authored-by: Sascha Schwarze <[email protected]>
  • Loading branch information
HeavyWombat and SaschaSchwarze0 committed Mar 12, 2024
1 parent cdcde8e commit 06eafce
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/validate/strategies.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func (s Strategy) validateBuildStrategy(ctx context.Context, strategyName string

if apierrors.IsNotFound(err) {
s.Build.Status.Reason = build.BuildReasonPtr(build.BuildStrategyNotFound)
s.Build.Status.Message = pointer.String(fmt.Sprintf("buildStrategy %s does not exist in namespace %s", s.Build.Spec.Strategy.Name, s.Build.Namespace))
s.Build.Status.Message = pointer.String(fmt.Sprintf("buildStrategy %s does not exist in namespace %s", strategyName, s.Build.Namespace))
return nil
}

Expand All @@ -87,7 +87,7 @@ func (s Strategy) validateClusterBuildStrategy(ctx context.Context, strategyName

if apierrors.IsNotFound(err) {
s.Build.Status.Reason = build.BuildReasonPtr(build.ClusterBuildStrategyNotFound)
s.Build.Status.Message = pointer.String(fmt.Sprintf("clusterBuildStrategy %s does not exist", s.Build.Spec.Strategy.Name))
s.Build.Status.Message = pointer.String(fmt.Sprintf("clusterBuildStrategy %s does not exist", strategyName))
return nil
}

Expand Down

0 comments on commit 06eafce

Please sign in to comment.