Skip to content

Commit

Permalink
Merge pull request #1494 from qu1queee/qu1queee/glint_1561
Browse files Browse the repository at this point in the history
Fix golangci-lint findings
  • Loading branch information
openshift-merge-bot[bot] authored Feb 13, 2024
2 parents 62e4673 + 9bf65ca commit 319d83c
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion pkg/reconciler/build/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func add(ctx context.Context, mgr manager.Manager, r reconcile.Reconciler, maxCo
// or BuildRunDeletion annotation does not change
return o.GetGeneration() != n.GetGeneration() || buildRunDeletionAnnotation
},
DeleteFunc: func(e event.DeleteEvent) bool {
DeleteFunc: func(_ event.DeleteEvent) bool {
// Never reconcile on deletion, there is nothing we have to do
return false
},
Expand Down
6 changes: 3 additions & 3 deletions pkg/reconciler/buildlimitcleanup/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,14 +75,14 @@ func add(mgr manager.Manager, r reconcile.Reconciler, maxConcurrentReconciles in
}
return false
},
DeleteFunc: func(e event.DeleteEvent) bool {
DeleteFunc: func(_ event.DeleteEvent) bool {
// Never reconcile on deletion, there is nothing we have to do
return false
},
}

predBuildRun := predicate.Funcs{
CreateFunc: func(e event.CreateEvent) bool {
CreateFunc: func(_ event.CreateEvent) bool {
// Never reconcile in case of create buildrun event
return false
},
Expand All @@ -106,7 +106,7 @@ func add(mgr manager.Manager, r reconcile.Reconciler, maxConcurrentReconciles in
}
return false
},
DeleteFunc: func(e event.DeleteEvent) bool {
DeleteFunc: func(_ event.DeleteEvent) bool {
// Never reconcile on deletion, there is nothing we have to do
return false
},
Expand Down
2 changes: 1 addition & 1 deletion pkg/reconciler/buildrun/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func add(mgr manager.Manager, r reconcile.Reconciler, maxConcurrentReconciles in

return false
},
DeleteFunc: func(e event.DeleteEvent) bool {
DeleteFunc: func(_ event.DeleteEvent) bool {
// Never reconcile on deletion, there is nothing we have to do
return false
},
Expand Down
2 changes: 1 addition & 1 deletion pkg/reconciler/buildrunttlcleanup/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ func add(mgr manager.Manager, r reconcile.Reconciler, maxConcurrentReconciles in

return false
},
DeleteFunc: func(e event.DeleteEvent) bool {
DeleteFunc: func(_ event.DeleteEvent) bool {
// Never reconcile on deletion, there is nothing we have to do
return false
},
Expand Down

0 comments on commit 319d83c

Please sign in to comment.