-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v1beta1 types #1235
Add v1beta1 types #1235
Conversation
565f149
to
b264e31
Compare
b264e31
to
b4af55f
Compare
c8fd656
to
c2487f8
Compare
|
||
// BuildSpec defines the desired state of Build | ||
type BuildSpec struct { | ||
// Source refers to the Git repository containing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source is more than Git.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edited.
ParamValues []ParamValue `json:"paramValues,omitempty"` | ||
|
||
// Output refers to the location where the built image would be pushed. | ||
Output Image `json:"output"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imo the type should be named Output like the key, that would be consistent with what we do anywhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, however I prefer this to be a separated item via its own issue.
c2487f8
to
13e64ac
Compare
- Set storage version to v1alpha API types - Extend code generation script to support v1beta1 API type
We exceeded the metadata.annotations size(over 262144 bytes), with the new types aggregation. Using --server-side flag ensures the last-applied-configuration annotation is not counted.
13e64ac
to
44d85f9
Compare
- Fixes on existing API fields - Modifications on existing API fields - Removals of unwanted or unnecessary API fields Coming from a pull request review. Signed-off-by: Sascha Schwarze <[email protected]>
Applies new changes on the v1beta1 API fields
@SaschaSchwarze0 pls re-review, thanks a lot for the first review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/hold
Adding hold for the ship to be merged first. But looks all good to me.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ship is merged. /unhold |
Changes
Fixes #1103
This work is based on shipwright-io/community#105 and https://hackmd.io/BsPjvGFwQgmVeJRe6FJfMA#Build-sources
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes