[WIP] Resolve fatal: detected dubious ownership in repository at '/workspace/source'

[coreydaley]

Changes

Append git command to add safe.directory of cloned source directory to config, which fixes:

[source-default] 2023/08/14 23:57:02 fatal: detected dubious ownership in repository at '/workspace/source'
#   [source-default] To add an exception for this directory, call:
#   [source-default] 
#   [source-default] 	git config --global --add safe.directory /workspace/source (exit code 128)

Fixes shipwright-io/cli#190

Submitter Checklist

• Includes tests if functionality changed/was added
• Includes docs if changes are user-facing
• Set a kind label on this PR
• Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Add cloned source directory to git config as safe.directory

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qu1queee for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coreydaley]

/kind failing-test

[SaschaSchwarze0]

In unit tests, the Git command runs on your local machine. We therefore want to prevent the use of git config --global. The safe.directory configuration is therefore set in the git function itself.

Is the CLI really running on the latest Build code and somehow causes a Git operation to fail with this? If so, then we must look at this specific command. Though, I somehow remember that the CLI runs the latest release in e2e - which would be v0.11? We can have a chat, I wonder if using the latest nightly somehow in the CLI would fix things.