Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure assets deletion use a sleep time #1386

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Ensure assets deletion use a sleep time #1386

merged 1 commit into from
Sep 21, 2023

Conversation

qu1queee
Copy link
Contributor

Changes

Introduce a sleep time when deleting assets from nightly release, recommended by github when hitting the secondary rate limits.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

@qu1queee qu1queee added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 20, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 20, 2023
@openshift-ci openshift-ci bot added the release-note-none Label for when a PR does not need a release note label Sep 20, 2023
@qu1queee
Ensure assets deletion use a sleep time
c17d1fd 
Recommended by github when hitting the secondary rate limits
SaschaSchwarze0
SaschaSchwarze0 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Is a little dissatisfying that the gh client does not simply honor Retry-After and does this implicitely for us ...

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2023
@openshift-merge-robot openshift-merge-robot merged commit 7efcfbe into shipwright-io:main Sep 21, 2023
12 checks passed
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.12.0 milestone Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaSchwarze0 SaschaSchwarze0 SaschaSchwarze0 approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

Assignees

@SaschaSchwarze0 SaschaSchwarze0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Shipwright Overview
Status: Done
Milestone
release-v0.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@qu1queee @SaschaSchwarze0 @openshift-merge-robot