Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: import packages only once #1387

Merged
merged 1 commit into from
Sep 25, 2023
Merged

chore: import packages only once #1387

merged 1 commit into from
Sep 25, 2023

Conversation

testwill
Copy link
Contributor

@testwill testwill commented Sep 22, 2023 •
edited by qu1queee
Loading

Changes

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 22, 2023
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Sep 22, 2023
@qu1queee qu1queee added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 22, 2023
@openshift-ci openshift-ci bot added release-note-none Label for when a PR does not need a release note and removed release-note Label for when a PR has specified a release note labels Sep 22, 2023
@qu1queee
Copy link
Contributor

@testwill I modified your PR comment, to have a release note, otherwise one CI test will fail. You can modify if you want as well, let me know.

qu1queee
qu1queee approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2023
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.12.0 milestone Sep 25, 2023
SaschaSchwarze0
SaschaSchwarze0 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2023
@openshift-merge-robot openshift-merge-robot merged commit fa7bea6 into shipwright-io:main Sep 25, 2023
13 checks passed
@testwill testwill deleted the pkg-import branch September 26, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qu1queee qu1queee qu1queee approved these changes

@SaschaSchwarze0 SaschaSchwarze0 SaschaSchwarze0 approved these changes

@HeavyWombat HeavyWombat Awaiting requested review from HeavyWombat

Assignees

@qu1queee qu1queee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Shipwright Overview
Status: Done
Milestone
release-v0.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@testwill @qu1queee @SaschaSchwarze0 @openshift-merge-robot