Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update e2e test cases for v1beta1 #1388

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Update e2e test cases for v1beta1 #1388

merged 2 commits into from
Oct 17, 2023

Conversation

apoorvajagtap
Copy link
Member

@apoorvajagtap apoorvajagtap commented Sep 26, 2023 •
edited by SaschaSchwarze0
Loading

Changes

Fixes #1373

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

Documentation was updated to describe the beta version of the custom resources

@openshift-ci openshift-ci bot added release-note-none Label for when a PR does not need a release note do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 26, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2023
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 26, 2023
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.12.0 milestone Oct 1, 2023
@apoorvajagtap apoorvajagtap changed the title [WIP] Update e2e test cases for v1beta1 Update e2e test cases for v1beta1 Oct 3, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2023
@apoorvajagtap
Copy link
Member Author

apoorvajagtap commented Oct 3, 2023 •
edited
Loading

/assign @coreydaley @jkhelil

@qu1queee qu1queee requested review from qu1queee and SaschaSchwarze0 and removed request for otaviof October 4, 2023 13:12
@apoorvajagtap apoorvajagtap force-pushed the BUILD-656 branch 2 times, most recently from 2bd9b85 to 001abfb Compare October 6, 2023 15:07
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 6, 2023
@apoorvajagtap apoorvajagtap force-pushed the BUILD-656 branch 4 times, most recently from 58ef394 to 73661f1 Compare October 6, 2023 16:59
@SaschaSchwarze0 SaschaSchwarze0 added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 9, 2023
@apoorvajagtap apoorvajagtap force-pushed the BUILD-656 branch 2 times, most recently from 80ff8f9 to e6b2475 Compare October 10, 2023 19:04
SaschaSchwarze0
SaschaSchwarze0 requested changes Oct 12, 2023
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase. We should then get a test result with all results and see what is wrong. A few TODOs I see, especially the missing source in the Beta BuildRun spec we must address.

pkg/apis/build/v1beta1/build_conversion.go Outdated Show resolved Hide resolved
samples/build/build_buildpacks-v3_cr.yaml Outdated Show resolved Hide resolved
samples/build/build_ko_cr.yaml Outdated Show resolved Hide resolved
test/data/v1beta1/buildrun_buildah_cr_local_source_upload.yaml Outdated Show resolved Hide resolved
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2023
@apoorvajagtap apoorvajagtap force-pushed the BUILD-656 branch 2 times, most recently from ca266f8 to ee28e4a Compare October 13, 2023 10:04
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2023
SaschaSchwarze0
SaschaSchwarze0 requested changes Oct 13, 2023
View reviewed changes
docs/build.md Outdated Show resolved Hide resolved
pkg/apis/build/v1beta1/build_conversion.go Show resolved Hide resolved
@apoorvajagtap apoorvajagtap force-pushed the BUILD-656 branch 2 times, most recently from 20d689a to 427fa24 Compare October 16, 2023 17:47
@apoorvajagtap
Updates e2e tests for v1beta1
f4f6eaa 
removes deprecated pointer references
SaschaSchwarze0
SaschaSchwarze0 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@openshift-ci openshift-ci bot merged commit 808f1a6 into shipwright-io:main Oct 17, 2023
12 checks passed
@SaschaSchwarze0 SaschaSchwarze0 mentioned this pull request Oct 17, 2023
Merged
4 tasks
@openshift-ci openshift-ci bot added release-note Label for when a PR has specified a release note and removed release-note-none Label for when a PR does not need a release note labels Oct 18, 2023
@SaschaSchwarze0 SaschaSchwarze0 added kind/documentation Categorizes issue or PR as related to documentation. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaSchwarze0 SaschaSchwarze0 SaschaSchwarze0 approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@qu1queee qu1queee Awaiting requested review from qu1queee

Assignees

@coreydaley coreydaley

@jkhelil jkhelil

@SaschaSchwarze0 SaschaSchwarze0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Shipwright Overview
Status: Done
Milestone
release-v0.12.0
Development

Successfully merging this pull request may close these issues.

[BETA API] With the v1beta1 changes introduced, need to determine the scope for test changes required
5 participants
@apoorvajagtap @SaschaSchwarze0 @coreydaley @jkhelil @openshift-merge-robot