Ensure conversion for local source takes place #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
pull-request-size
bot
added
the
size/S
openshift-ci
bot
added
the
release-note
pull-request-size
bot
added
size/M
qu1queee
force-pushed
the
qu1queee/conversion_local_source
branch
from
28d2e96
to
506fd72
Compare
pull-request-size
bot
added
size/L
qu1queee
force-pushed
the
qu1queee/conversion_local_source
branch
2 times, most recently
from
620bd2f
to
416c26a
Compare
qu1queee
added
kind/documentation
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
- Introduce missing localType object in spec.source for Build - Introduce new spec.source object for BuildRun - Ensure conversion for spec.sources in Build or spec.sources in BuildRun can convert to the spec.source for beta
- Validate conversion from beta to alpha, alpha to beta, for the Build CR's. - Validate conversion from beta to alpha, alpha to beta, for the BuildRun CR's.
Due to seeing panics reported in issues, when this field for v1beta1 CR's was not set by human error.
qu1queee
force-pushed
the
qu1queee/conversion_local_source
branch
from
c776d8b
to
9ef8506
Compare
pull-request-size
bot
added
size/XL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add conversion for local type. Previously local type was supported under
.spec.sourcesfor Builds and Buildruns( v1alpha1 ). In this PR, we move local sources as the third supported type for.spec.sourcein Builds( v1beta1 ) and as the only supported type in.spec.sourcein BuildRuns( v1beta1 ).Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes