Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed buildCredentialserences function name #1506

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Fixed buildCredentialserences function name #1506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/validate/secrets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func (s Credentials) ValidatePath(ctx context.Context) error {
var missingSecrets []string
secret := &corev1.Secret{}

secretNames := s.buildCredentialserences()
secretNames := s.buildCredentialReferences()

for refSecret, secretType := range secretNames {
if err := s.Client.Get(ctx, types.NamespacedName{Name: refSecret, Namespace: s.Build.Namespace}, secret); err != nil && !apierrors.IsNotFound(err) {
Expand All @@ -58,7 +58,7 @@ func (s Credentials) ValidatePath(ctx context.Context) error {
return nil
}

func (s Credentials) buildCredentialserences() map[string]build.BuildReason {
func (s Credentials) buildCredentialReferences() map[string]build.BuildReason {
// Validate if the referenced secrets exist in the namespace
secretRefMap := map[string]build.BuildReason{}
if s.Build.Spec.Output.PushSecret != nil {
Expand Down
Loading