Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Heruko buildpacks samples that failed to determine the target OS #1511

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Fix Heruko buildpacks samples that failed to determine the target OS #1511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion samples/v1alpha1/buildstrategy/buildpacks-v3/buildstrategy_buildpacks-v3-heroku_cr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,23 @@ spec:
- name: platform-env
emptyDir: {}
parameters:
- name: operating-system
description: The target operating system for the buildpacks build.
default: "linux"
- name: system-architecture
description: The target system architecture for the buildpacks build.
default: "x86_64"
- name: platform-api-version
description: The referenced version is the minimum version that all relevant buildpack implementations support.
default: "0.7"
buildSteps:
- name: build-and-push
image: heroku/builder:22
env:
- name: CNB_TARGET_OS
value: $(params.operating-system)
- name: CNB_TARGET_ARCH
value: $(params.system-architecture)
- name: CNB_PLATFORM_API
value: $(params.platform-api-version)
- name: PARAM_SOURCE_CONTEXT
Expand Down Expand Up @@ -62,7 +72,7 @@ spec:
mkdir -p "$CACHE_DIR" "$LAYERS_DIR"

function announce_phase {
printf "===> %s\n" "$1"
printf "===> %s\n" "$1"
}

announce_phase "ANALYZING"
Expand Down
10 changes: 10 additions & 0 deletions ...1alpha1/buildstrategy/buildpacks-v3/buildstrategy_buildpacks-v3-heroku_namespaced_cr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,23 @@ spec:
- name: platform-env
emptyDir: {}
parameters:
- name: operating-system
description: The target operating system for the buildpacks build.
default: "linux"
- name: system-architecture
description: The target system architecture for the buildpacks build.
default: "x86_64"
- name: platform-api-version
description: The referenced version is the minimum version that all relevant buildpack implementations support.
default: "0.7"
buildSteps:
- name: build-and-push
image: heroku/builder:22
env:
- name: CNB_TARGET_OS
value: $(params.operating-system)
- name: CNB_TARGET_ARCH
value: $(params.system-architecture)
- name: CNB_PLATFORM_API
value: $(params.platform-api-version)
- name: PARAM_SOURCE_CONTEXT
Expand Down
12 changes: 11 additions & 1 deletion samples/v1beta1/buildstrategy/buildpacks-v3/buildstrategy_buildpacks-v3-heroku_cr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,23 @@ spec:
- name: platform-env
emptyDir: {}
parameters:
- name: operating-system
description: The target operating system for the buildpacks build.
default: "linux"
- name: system-architecture
description: The target system architecture for the buildpacks build.
default: "x86_64"
- name: platform-api-version
description: The referenced version is the minimum version that all relevant buildpack implementations support.
default: "0.7"
steps:
- name: build-and-push
image: heroku/builder:22
env:
- name: CNB_TARGET_OS
value: $(params.operating-system)
- name: CNB_TARGET_ARCH
value: $(params.system-architecture)
- name: CNB_PLATFORM_API
value: $(params.platform-api-version)
- name: PARAM_SOURCE_CONTEXT
Expand Down Expand Up @@ -62,7 +72,7 @@ spec:
mkdir -p "$CACHE_DIR" "$LAYERS_DIR"

function announce_phase {
printf "===> %s\n" "$1"
printf "===> %s\n" "$1"
}

announce_phase "ANALYZING"
Expand Down
10 changes: 10 additions & 0 deletions ...v1beta1/buildstrategy/buildpacks-v3/buildstrategy_buildpacks-v3-heroku_namespaced_cr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,23 @@ spec:
- name: platform-env
emptyDir: {}
parameters:
- name: operating-system
description: The target operating system for the buildpacks build.
default: "linux"
- name: system-architecture
description: The target system architecture for the buildpacks build.
default: "x86_64"
- name: platform-api-version
description: The referenced version is the minimum version that all relevant buildpack implementations support.
default: "0.7"
steps:
- name: build-and-push
image: heroku/builder:22
env:
- name: CNB_TARGET_OS
value: $(params.operating-system)
- name: CNB_TARGET_ARCH
value: $(params.system-architecture)
- name: CNB_PLATFORM_API
value: $(params.platform-api-version)
- name: PARAM_SOURCE_CONTEXT
Expand Down
Loading