Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test two different Tekton versions in e2e and integration tests #1649

Conversation

SaschaSchwarze0
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 commented Jul 21, 2024

Changes

As discussed in the last community meeting, this PR changes the e2e and integration to test two different Tekton versions.

We could actually think about automation that automatically updates the newest LTS version.

We will need to red-merge this one to then change the branch configuration to the changed check names that this change introduces.

Part of #1640

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

Shipwright Build is now validated on the oldest supported and the newest available Tekton LTS releases

@SaschaSchwarze0 SaschaSchwarze0 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 21, 2024
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Jul 21, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 21, 2024
@openshift-ci openshift-ci bot requested review from HeavyWombat and karanibm6 July 21, 2024 13:55
Copy link
Contributor

@karanibm6 karanibm6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2024
@qu1queee qu1queee requested review from qu1queee and removed request for HeavyWombat July 23, 2024 05:36
@qu1queee
Copy link
Contributor

@SaschaSchwarze0 you need to file an issue for automating this imho, otherwise its gonna be manual work every 3 months

Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0844f03 into shipwright-io:main Jul 23, 2024
17 checks passed
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-two-tekton-versions branch August 7, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants