Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unused variables #222

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Fix unused variables #222

merged 1 commit into from
Mar 1, 2024

Conversation

SaschaSchwarze0
Copy link
Member

Changes

This fixes the new golangci-lint findings that currently block pull requests.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

NONE

@SaschaSchwarze0 SaschaSchwarze0 added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Feb 13, 2024
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.13.0 milestone Feb 13, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 13, 2024
@SaschaSchwarze0 SaschaSchwarze0 mentioned this pull request Feb 25, 2024
Closed
HeavyWombat
HeavyWombat approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@HeavyWombat HeavyWombat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HeavyWombat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 09cd646 into shipwright-io:main Mar 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeavyWombat HeavyWombat HeavyWombat approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@coreydaley coreydaley Awaiting requested review from coreydaley

@qu1queee qu1queee Awaiting requested review from qu1queee

Assignees

@HeavyWombat HeavyWombat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Shipwright Overview
Status: Done
Milestone
release-v0.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SaschaSchwarze0 @HeavyWombat