Adds flag to add paramValues #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
apoorvajagtap
force-pushed
the
issue#224
branch
3 times, most recently
from
39d8e69
to
e27bbe5
Compare
|
@apoorvajagtap please rebase this pull request. The |
SaschaSchwarze0
force-pushed
the
issue#224
branch
2 times, most recently
from
8994182
to
df4b794
Compare
|
@apoorvajagtap I rebased your branch and also regenerated the documentation with the new flags. It would be all ready, but I cannot sign your commit, so need you to get this updated. |
This commit enables the option to pass custom/required parameters via CLI while creating the build or buildRun. Signed-off-by: apoorvajagtap <[email protected]>
Signed-off-by: Sascha Schwarze <[email protected]>
apoorvajagtap
force-pushed
the
issue#224
branch
from
df4b794
to
2d4bfb7
Compare
|
Thanks @SaschaSchwarze0! I have signed off my commit. I believe the PR is ready to proceed further. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
SaschaSchwarze0
added
the
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commit enables the option to pass custom/required parameters via CLI while creating the build or buildRun.
Fixes #224
Submitter Checklist
Release Notes