Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD MAINTAINERS file #242

Merged
merged 1 commit into from
Sep 27, 2024
Merged

ADD MAINTAINERS file #242

merged 1 commit into from
Sep 27, 2024

Conversation

qu1queee
Copy link
Contributor

Changes

Related to #240

This document is based on https://contribute.cncf.io/maintainers/templates/maintainers/ . Although we have not yet defined roles, I'm adding in the list the admin and maintainer. Once we define the governance doc, I expect those two roles to be there, per Github Roles and Responsabilities

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 20, 2024
Copy link

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qu1queee. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Add explicit note on written, open governance.

Signed-off-by: encalada <[email protected]>
@qu1queee
Copy link
Contributor Author

qu1queee commented Sep 27, 2024

@SaschaSchwarze0 @adambkaplan I'm proceeding to merge this PR; per the lack of a review on a timely manner. As discussed offline before, the list should be accurate. The contents might be subject to change(only the Responsibility column).

Note: the urgency is related to the CNCF onboarding. As a reference, see the approvers list under the OWNERS.md file, is the same list.

@qu1queee qu1queee merged commit 4e23047 into main Sep 27, 2024
1 of 2 checks passed
@qu1queee qu1queee deleted the qu1queee/maintainers_docs branch September 27, 2024 07:11
@adambkaplan
Copy link
Member

Belated LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants