Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize controller-gen Results #23

Closed
otaviof opened this issue Oct 7, 2021 · 4 comments
Closed

Standardize controller-gen Results #23

otaviof opened this issue Oct 7, 2021 · 4 comments
Labels
kind/flake Categorizes issue or PR as related to a flaky test.

Comments

@otaviof
Copy link
Member

otaviof commented Oct 7, 2021

Recently we noticed the outcomes of controller-gen can be different on GitHub Actions (Ubuntu based) than on our workstations.

What can we do in order to make sure controller-gen will produce the exact same outcomes, regardless where it's being executed?

@otaviof otaviof added the kind/flake Categorizes issue or PR as related to a flaky test. label Oct 7, 2021
@gabemontero
Copy link
Member

cross referencing with the analogous item shipwright-io/build#832 that I opened in shipwright-io/builds

in theory the solution devised there can be copied and pasted here

@coreydaley
Copy link
Contributor

kubernetes-sigs/controller-tools#623 was opened by @akram

@adambkaplan
Copy link
Member

I think this issue was closed - we recently updated controller-gen, and this seems to have addressed the issue.

/close

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2022

@adambkaplan: Closing this issue.

In response to this:

I think this issue was closed - we recently updated controller-gen, and this seems to have addressed the issue.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this as completed Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/flake Categorizes issue or PR as related to a flaky test.
Projects
None yet
Development

No branches or pull requests

4 participants