report available status for shipwright build object #14

jkhelil · 2021-07-09T09:18:34Z

Changes

Report available status for shipwright build

Submitter Checklist

Includes tests if functionality changed/was added
Includes docs if changes are user-facing
Set a kind label on this PR
Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

When the Shipwright build controller is deployed, the ShipwrightBuild object now reports the available status of the build controller

gabemontero · 2021-07-09T13:15:38Z

/assign @adambkaplan
/assign @otaviof

coreydaley

I think that the Kubernetes way of logging is to only start Errors with lower case letters (and maybe Debug is ok also?), and the rest like Info all start with upper case.
I believe it is the same with condition messages also.

api/v1alpha1/shipwrightbuild_types.go

cmd/operator/main.go

controllers/shipwrightbuild_controller.go

otaviof

Thanks, Corey!

/lgtm

api/v1alpha1/shipwrightbuild_types.go

controllers/shipwrightbuild_controller.go

otaviof · 2021-08-16T15:58:50Z

@jkhelil thanks for the PR, it looks good! I'll add the label back again.

/lgtm

adambkaplan

Minor items, otherwise looks good.

controllers/shipwrightbuild_controller.go

adambkaplan · 2021-08-16T20:13:14Z

Verify check failed - run `make manifests` and commit the resulting changes to git.

adambkaplan · 2021-08-17T14:30:10Z

@jkhelil looks like the update to the API also requires changes to the OLM bundle resource:

Verify check failed - run `make bundle` and commit the resulting changes to git.

adambkaplan · 2021-08-31T18:15:46Z

@jkhelil please review the submitter checklist:

PR needs testing. At minimum the unit test should verify that we're creating the Ready status condition. See https://github.com/shipwright-io/operator/blob/main/controllers/shipwrightbuild_controller_test.go#L130-L131. Unfortunately we don't really have e2e tests yet.
Needs docs - we don't have API docs yet. I recommend creating a shipwrightbuild.md file under docs/ to start an API reference.
Needs a release note - the PR description needs a code block that starts with "```release-note"

adambkaplan · 2021-08-31T18:15:56Z

/kind feature

adambkaplan · 2021-08-31T18:39:18Z

It may be easier to update our "default" ginkgo tests to check that status is being set correctly:

https://github.com/shipwright-io/operator/blob/main/controllers/default_test.go

gabemontero · 2021-10-05T12:13:55Z

/approve
/lgtm

jkhelil · 2021-10-06T12:53:41Z

@adambkaplan can ou approve please

api/v1alpha1/shipwrightbuild_types.go

adambkaplan · 2021-10-05T13:00:10Z

bundle/manifests/operator.shipwright.io_shipwrightbuilds.yaml

@@ -42,7 +42,79 @@ spec:
                type: string
            type: object
          status:
-            description: ShipwrightBuildStatus defines the observed state of Shipwright-Build
+            description: ShipwrightBuildStatus defines the observed state of ShipwrightBuild


Yes - @otaviof please write this up in a GitHub issue here.

otaviof · 2021-10-07T17:30:48Z

@jkhelil Having a look on the lastest CI run, I think the flag -ginkgo.v is not working anymore, we should instead use -test.v. Please have a look.

jkhelil · 2021-10-08T07:10:52Z

@jkhelil Having a look on the lastest CI run, I think the flag -ginkgo.v is not working anymore, we should instead use -test.v. Please have a look.

replaced with -test.v -test.failfast

adambkaplan

One last style item on the unit test.

api/v1alpha1/shipwrightbuild_types_test.go

adambkaplan

/approve

/lgtm

openshift-ci · 2021-10-20T18:28:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [adambkaplan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

adambkaplan · 2021-10-20T18:28:50Z

Docs to be addressed in #24

adambkaplan · 2021-10-27T15:00:57Z

This fixed #7

openshift-ci bot added the release-note label Jul 9, 2021

openshift-ci bot requested review from otaviof and SaschaSchwarze0 July 9, 2021 09:18

openshift-ci bot assigned adambkaplan and otaviof Jul 9, 2021

coreydaley suggested changes Jul 9, 2021

View reviewed changes

jkhelil force-pushed the BUILD-259 branch from f927a38 to 61e93a1 Compare July 12, 2021 10:17

otaviof approved these changes Jul 20, 2021

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2021

jkhelil force-pushed the BUILD-259 branch from 61e93a1 to 71f5fa4 Compare August 3, 2021 12:45

openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels Aug 3, 2021

jkhelil force-pushed the BUILD-259 branch from 71f5fa4 to 5b5d247 Compare August 12, 2021 14:09

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2021

akram suggested changes Aug 16, 2021

View reviewed changes

jkhelil force-pushed the BUILD-259 branch from 5b5d247 to 7d8e375 Compare August 16, 2021 12:17

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2021

adambkaplan requested changes Aug 16, 2021

View reviewed changes

controllers/shipwrightbuild_controller.go Show resolved Hide resolved

controllers/shipwrightbuild_controller.go Outdated Show resolved Hide resolved

controllers/shipwrightbuild_controller.go Outdated Show resolved Hide resolved

controllers/shipwrightbuild_controller.go Show resolved Hide resolved

jkhelil force-pushed the BUILD-259 branch from 7d8e375 to 9ae0fbb Compare August 17, 2021 08:49

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2021

jkhelil force-pushed the BUILD-259 branch from 9ae0fbb to 5b9a1ff Compare August 17, 2021 08:52

jkhelil force-pushed the BUILD-259 branch from 5b9a1ff to 6a20317 Compare August 31, 2021 12:24

openshift-ci bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 31, 2021

gabemontero mentioned this pull request Oct 4, 2021

tests for error scenarios #22

Open

openshift-ci bot assigned gabemontero Oct 5, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2021

adambkaplan added this to the release-v0.6.0 milestone Oct 6, 2021

adambkaplan reviewed Oct 6, 2021

View reviewed changes

jkhelil force-pushed the BUILD-259 branch from 347bafb to 92eaef1 Compare October 7, 2021 06:22

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2021

otaviof mentioned this pull request Oct 7, 2021

Standardize controller-gen Results #23

Closed

jkhelil force-pushed the BUILD-259 branch 3 times, most recently from 4fdecb9 to b8ea1dc Compare October 7, 2021 15:25

adambkaplan reviewed Oct 8, 2021

View reviewed changes

api/v1alpha1/shipwrightbuild_types_test.go Outdated Show resolved Hide resolved

add shipwright build status

487f267

jkhelil force-pushed the BUILD-259 branch from beaf22e to 487f267 Compare October 11, 2021 06:57

adambkaplan approved these changes Oct 20, 2021

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2021

openshift-merge-robot merged commit e8dfb0e into shipwright-io:main Oct 20, 2021

adambkaplan mentioned this pull request Oct 27, 2021

Report Available status in conditions #7

Closed

SaschaSchwarze0 mentioned this pull request May 16, 2022

Enable dependabot updates #75

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

report available status for shipwright build object #14

report available status for shipwright build object #14

jkhelil commented Jul 9, 2021 •

edited by gabemontero

Loading

gabemontero commented Jul 9, 2021

coreydaley left a comment

otaviof left a comment

otaviof commented Aug 16, 2021

adambkaplan left a comment

adambkaplan commented Aug 16, 2021

adambkaplan commented Aug 17, 2021

adambkaplan commented Aug 31, 2021 •

edited

Loading

adambkaplan commented Aug 31, 2021

adambkaplan commented Aug 31, 2021

gabemontero commented Oct 5, 2021

jkhelil commented Oct 6, 2021

adambkaplan Oct 5, 2021

otaviof commented Oct 7, 2021

jkhelil commented Oct 8, 2021

adambkaplan left a comment

adambkaplan left a comment

openshift-ci bot commented Oct 20, 2021

adambkaplan commented Oct 20, 2021

adambkaplan commented Oct 27, 2021

report available status for shipwright build object #14

report available status for shipwright build object #14

Conversation

jkhelil commented Jul 9, 2021 • edited by gabemontero Loading

Changes

Submitter Checklist

Release Notes

gabemontero commented Jul 9, 2021

coreydaley left a comment

Choose a reason for hiding this comment

otaviof left a comment

Choose a reason for hiding this comment

otaviof commented Aug 16, 2021

adambkaplan left a comment

Choose a reason for hiding this comment

adambkaplan commented Aug 16, 2021

adambkaplan commented Aug 17, 2021

adambkaplan commented Aug 31, 2021 • edited Loading

adambkaplan commented Aug 31, 2021

adambkaplan commented Aug 31, 2021

gabemontero commented Oct 5, 2021

jkhelil commented Oct 6, 2021

adambkaplan Oct 5, 2021

Choose a reason for hiding this comment

otaviof commented Oct 7, 2021

jkhelil commented Oct 8, 2021

adambkaplan left a comment

Choose a reason for hiding this comment

adambkaplan left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Oct 20, 2021

adambkaplan commented Oct 20, 2021

adambkaplan commented Oct 27, 2021

jkhelil commented Jul 9, 2021 •

edited by gabemontero

Loading

adambkaplan commented Aug 31, 2021 •

edited

Loading