-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report available status for shipwright build object #14
Conversation
/assign @adambkaplan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the Kubernetes way of logging is to only start Errors
with lower case letters (and maybe Debug
is ok also?), and the rest like Info
all start with upper case.
I believe it is the same with condition messages also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Corey!
/lgtm
@jkhelil thanks for the PR, it looks good! I'll add the label back again. /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor items, otherwise looks good.
|
@jkhelil looks like the update to the API also requires changes to the OLM bundle resource:
|
@jkhelil please review the submitter checklist:
|
/kind feature |
It may be easier to update our "default" ginkgo tests to check that status is being set correctly: https://github.com/shipwright-io/operator/blob/main/controllers/default_test.go |
/approve |
@adambkaplan can ou approve please |
@@ -42,7 +42,79 @@ spec: | |||
type: string | |||
type: object | |||
status: | |||
description: ShipwrightBuildStatus defines the observed state of Shipwright-Build | |||
description: ShipwrightBuildStatus defines the observed state of ShipwrightBuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - @otaviof please write this up in a GitHub issue here.
4fdecb9
to
b8ea1dc
Compare
@jkhelil Having a look on the lastest CI run, I think the flag |
replaced with -test.v -test.failfast |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last style item on the unit test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Docs to be addressed in #24 |
This fixed #7 |
Changes
Report available status for shipwright build
#7
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes