Bump dependencies to align with Build v0.12.0 #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
do-not-merge/work-in-progress
adambkaplan
added
the
kind/dependency-change
adambkaplan
force-pushed
the
bump-controller-runtime-v0.14.6
branch
from
cfd6de0
to
77553e9
Compare
|
/hold This should wait for #164 to be merged first, as it builds on top of its commits. |
openshift-ci
bot
added
the
do-not-merge/hold
adambkaplan
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/approve Self-approving |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
This was referenced Nov 2, 2023
Closed
In preparation of bringing in shipwright-io/build as a dependency, the following dependencies needed to be updated concurrently due to transitive dependencies on k8s.io libraries: - controller-runtime: update to v0.14.6 to align with shipwright-io/build - tektoncd/operator: update to v0.67.0 to align with controller-runtime - k8s.io/* to v0.26.4 (a common patch version) - onsi/ginkgo to v2 (from controller-runtime)
- Utilize ginkgo/v2 SpecContext to handle graceful termination. A separate context was created to isolate EnvTest from any "client" contexts used during tests and avoid deadlocks. - Use v1.26 for EnvTest-driven tests. - Re-generate manifests and bundle
Update KinD to latest released version (v0.20.0) and use the supported v1.24 k8s node version from the corresponding release note. The current Tekton operator on OperatorHub does not support k8s 1.25 or higher. This also sets the minKubeVersion to 1.24.0 on the operator CSV so the version we test with and the min supported version are aligned. See tektoncd/operator#1493.
adambkaplan
force-pushed
the
bump-controller-runtime-v0.14.6
branch
from
77553e9
to
eb706b7
Compare
openshift-ci
bot
added
release-note-action-required
and removed
lgtm
|
Rebased. Added |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update the dependencies so we can bring in shipwright-io/build v0.12.0 as a new dependency. This is needed to support #155
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes