Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install build strategies via operator #171

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Install build strategies via operator #171

merged 2 commits into from
Nov 7, 2023

Commits on Nov 6, 2023

  1. bump(*): Add shipwright-io/build v0.12.0 

    Add shipwright-io/build v0.12.0 as a dependency, with additional
updates via `go get`:

- Update ginkgo to v2.13.0
- Update k8s.io/* to v0.26.9
    @adambkaplan
    adambkaplan committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    0d64e38 View commit details
    Browse the repository at this point in the history

  2. feat: Install Cluster Build Strategies with Operator 

    Install the build strategy samples from shipwright-io/build, at the
v0.12.0 tag. Only cluster build strategies were added - namespace scoped
build strategies were dropped. Red Hat-specific strategies were also
dropped, in part to avoid potential trademark issues. The build strategies
use v1alpha1 APIs because this is the stored version in v0.12.0. Testing
revealed that if we reconciled v1beta1 APIs, we would need to wait for
(and mock out!) the conversion webhook deployment. Lastly, the operator
was granted RBAC permission to administer all ClusterBuildStrategies.

Reconciling build strategies required adding logic to wait for the
required CRDs to be installed on the cluster first. If a requeue is
required, the operator will report the Ready status condition as "Unknown."
The manifestival library code also had to enhanced to optionally recurse
a directory for manifests to deploy.

Finally, development of this feature revealed refactoring opportunities
with respect to our use of k8s and controller-runtime client libraries, and
the way we are organizing/managing Manifestival-driven reconcilers. Some
refactoring of test code was included to simplify future testing efforts.
    @adambkaplan
    adambkaplan committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    d423d71 View commit details
    Browse the repository at this point in the history