Source release.yaml from GitHub release #208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `release.yaml` used as the base for deploying Shipwright Builds appears to have been manipulated by a YAML linter or other processor. There are significant differentes in YAML structure and formatting between the `kodata/release.yaml` in tree and the `release.yaml` published on GitHub for the respective release (v0.12.0). This makes it difficult to verify that the operator is deploying the right thing, especially when versions are bumped. This replaces the `kodata/release.yaml` in tree with the `release.yaml` published for v0.12.0. This will make it easy to verify that we are deploying the right version of Shipwright Builds with the operator, as well as support future workflows that let contributors update the deployed operand from a nightly release. Signed-off-by: Ayush Satyam <[email protected]>
pull-request-size
bot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ayushsatyam146 Is this the same/exact content as #182 (just rebased?). I updated my original PR - with an additional commit that addressed an RBAC issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The
release.yamlused as the base for deploying Shipwright Builds appears to have been manipulated by a YAML linter or other processor. There are significant differentes in YAML structure and formatting between thekodata/release.yamlin tree and therelease.yamlpublished on GitHub for the respective release (v0.12.0). This makes it difficult to verify that the operator is deploying the right thing, especially when versions are bumped.This replaces the
kodata/release.yamlin tree with therelease.yamlpublished for v0.12.0. This will make it easy to verify that we are deploying the right version of Shipwright Builds with the operator, as well as support future workflows that let contributors update the deployed operand from a nightly release.Fixes #184
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes