-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support exposure analysis + tests #8
base: master
Are you sure you want to change the base?
Conversation
tests/roxctl/bats-tests/local/roxctl-netpol-connectivity-map-release.bats
Outdated
Show resolved
Hide resolved
should also update documentation at https://github.com/shireenf-ibm/stackrox/tree/master/roxctl/netpol/connectivity/map |
defaultOutputFileNamePrefix = "connlist." | ||
defaultOutputFormat = "txt" | ||
defaultOutputFileNamePrefix = "connlist." | ||
exposureOutputFileNamePrefix = "exposure." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this required? it's the same connlist command, so I would not change the name of the default file name based on some arg...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see.
i did this for case we want to run on same dir twice (with and without the exposure
flag, thought maybe not to "erase" previous results), however a user may choose to provide his output file name to avoid this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Missing also tests with |
|
3c8dd94
to
51f289c
Compare
looks good! let's update this branch with most recent main of stackrox |
defaultOutputFileNamePrefix = "connlist." | ||
defaultOutputFormat = "txt" | ||
defaultOutputFileNamePrefix = "connlist." | ||
exposureOutputFileNamePrefix = "exposure." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this prefix exposure.
be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had a comment about this previously, (marked resolved) now marked as unresolved..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it should, the rebase was not successful (some commits were not picked)
i am working on fixing this
6741a1c
to
21bffdb
Compare
This reverts commit 51f289c.
e42ee5a
to
3ca4bd9
Compare
Co-authored-by: Piotr Rygielski <[email protected]>
Co-authored-by: Piotr Rygielski <[email protected]>
Description
-netpol-analyzer
is imported locally ingo.mod