feat(mem): Add windows commit stats #1720
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm kinda puzzled if I should avoid calling
procGetPerformanceInfo
and stick to computing commit stats frommemoryStatusEx.ullTotalPageFile
andmemoryStatusEx.ullAvailPageFile
or expose pagefile stats and compute it in final application.However, I chose this implementation because it is more aligned with the terminology used by Windows Task Manager and Powershell's
Get-Counter
, both of which refer to "commit" rather than "pagefile."Closes #1719