Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mem): possible memory leak on Windows #1722

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix(mem): possible memory leak on Windows #1722

merged 1 commit into from
Oct 11, 2024

Conversation

uubulb
Copy link
Contributor

@uubulb uubulb commented Oct 5, 2024

Call PdhCloseQuery after a PdhOpenQuery call

shirou
shirou approved these changes Oct 11, 2024
View reviewed changes
Copy link
Owner

@shirou shirou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thank you so much!

There might be similar issues in other functions on Windows as well, so I plan to investigate later and submit a PR if necessary (or PR is always welcome!)

@shirou shirou merged commit 44c71b6 into shirou:master Oct 11, 2024
23 checks passed
@Terminator-ux Terminator-ux mentioned this pull request Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirou shirou shirou approved these changes

Assignees
No one assigned
Labels
package:mem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uubulb @shirou