Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openbsd] set ConnectionsPid to return NotImplemented #1757

Merged
merged 2 commits into from
Dec 23, 2024
Merged

[openbsd] set ConnectionsPid to return NotImplemented #1757

merged 2 commits into from
Dec 23, 2024

Conversation

tuftedocelot
Copy link
Contributor

Seems to fix building latest telegraf on OpenBSD

@tuftedocelot
[openbsd] set ConnectionsPid to return NotImplemented
88d6de0 
netstat on OpenBSD doesn't provide PID information for open ports
@shirou
Copy link
Owner

shirou commented Dec 21, 2024

There are several functions similar to ConnectionsPid, such as

  • Connections
  • ConnectionsMax
  • ConnectionsWithoutUids
  • ConnectionsPid
  • ConnectionsPidWithoutUids
  • ConnectionsPidMax
  • ConnectionsPidMaxWithoutUids

I think these functions also should be added in openbsd.

@tuftedocelot
Copy link
Contributor Author

Something more like this? These were all taken from net/net_unix.go more or less verbatim

shirou
shirou approved these changes Dec 23, 2024
View reviewed changes
Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thank you so much!
(In other modules, functions without WithContext are grouped together in a single file. I plan to make this change in a another PR.)

@shirou shirou merged commit 6ee5668 into shirou:master Dec 23, 2024
23 checks passed
@tuftedocelot tuftedocelot deleted the connectionspid branch December 23, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirou shirou shirou approved these changes

Assignees
No one assigned
Labels
package:net
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuftedocelot @shirou