Merge pull request #2 from shlinkio/feature/fix-select

Fix select call with array instead of variadic args
shlinkio · Feb 17, 2024 · ac1c4e0 · ac1c4e0
2 parents 1037b7d + ec0a77e
commit ac1c4e0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Query/Select.php b/src/Query/Select.php
@@ -24,6 +24,6 @@ final class Select extends AbstractSelect
      */
     protected function modifySelection(QueryBuilder $qb, array $selections): void
     {
-        $qb->select($selections);
+        $qb->select(...$selections);
     }
 }
diff --git a/tests/Query/SelectSpec.php b/tests/Query/SelectSpec.php
@@ -42,21 +42,21 @@ public function it_is_a_query_modifier(): void
 
     public function it_select_single_filed(QueryBuilder $qb): void
     {
-        $qb->select(['a.foo'])->shouldBeCalled()->willReturn($qb);
+        $qb->select('a.foo')->shouldBeCalled()->willReturn($qb);
         $this->modify($qb, 'a');
     }
 
     public function it_select_several_fields(QueryBuilder $qb): void
     {
         $this->beConstructedWith('foo', 'bar');
-        $qb->select(['b.foo', 'b.bar'])->shouldBeCalled()->willReturn($qb);
+        $qb->select('b.foo', 'b.bar')->shouldBeCalled()->willReturn($qb);
         $this->modify($qb, 'b');
     }
 
     public function it_select_operand(QueryBuilder $qb): void
     {
         $this->beConstructedWith('foo', new Field('bar'));
-        $qb->select(['b.foo', 'b.bar'])->shouldBeCalled()->willReturn($qb);
+        $qb->select('b.foo', 'b.bar')->shouldBeCalled()->willReturn($qb);
         $this->modify($qb, 'b');
     }
 }