Create a factory service that can create GeoIp2\Database\Reader instances at runtime #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #59
Part of shlinkio/shlink#2021
This PR stops using and registering
GeoIp2\Database\Reader
as a singleton service, and instead provides a new factory service which creates Reader instances at runtime.This is needed because
GeoIp2\Database\Reader
instances are stateful, and they hold a reference to the metadata of the first file they were created with.The new service will ensure every time an interaction with the GeoLite2 file is needed, it will be done with an up-to-date copy.