Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GeoLite2Options via inline factory instead of ValinorConfigFactory #64

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Oct 24, 2024

No description provided.

@acelaya acelaya merged commit 0619112 into shlinkio:main Oct 24, 2024
7 checks passed
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (8538f70) to head (79cc636).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #64   +/-   ##
=========================================
  Coverage     98.98%   98.98%           
  Complexity       35       35           
=========================================
  Files            11       11           
  Lines            99       99           
=========================================
  Hits             98       98           
  Misses            1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya deleted the feature/remove-valinor-factory branch October 24, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant