Ensure non-bot values are printed if value is zero #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelaya
commented
Jan 2, 2025
| [true, 0, () => { | ||
| expect(screen.getByText('0')).toBeInTheDocument(); | ||
| expect(screen.queryByText('50')).not.toBeInTheDocument(); | ||
| }], |
There was a problem hiding this comment.
This test fails with previous logic
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
==========================================
- Coverage 77.36% 77.35% -0.02%
==========================================
Files 177 177
Lines 7247 7247
Branches 1505 1504 -1
==========================================
- Hits 5607 5606 -1
Misses 162 162
- Partials 1478 1479 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do an explicit
undefinedcheck fornonBotswhen evaluating if the bots or non-bots visits should be displayed in overview visits cards, to make sure the value is displayed when it's zero.