Close connections after every async job that uses the db #2342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2341
Decorate
UpdateGeoLiteDb
andSendVisitToMatomo
with theCloseDbConnectionEventListener
.That ensures any database connection opened for them is closed afterwards, which is specially important for the geolite one, as it runs for every single visit.
This job didn't use to interact with the database before Shlink 4.4, so it was intentionally not decorated.
SendVisitToMatomo
has always interacted with the database, it was just overlooked, but anyone not using this feature would not notice it.