Abrandoned/non block #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… .... also update send => send_data
…dable when attempting to write as SSL cmay need an internal read
|
@abrandoned @shokai I know this is ~ two years old but any chance this could be merged into the upstream repo? I've been incorporating this library into a project I'm working on wipple and need a way to attempt to connect to a websocket server in a non-blocking fashion (so that if the connection fails to be established I can easily terminate the socket and try again). I tried this PR out locally and it works great (though admitadely didn't go into the code in details). If this is just an issue of updating the PR to fix the CI failures, I can dedicate some time to investigating sending a followup PR addressing the problem. Just let me know. And thanks for the great library and PR!!! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is wanted/needed/desired but updated sockets to use non_blocking calls and making the handshake synchronous (as it was a confusing part to troubleshoot when failure)