Set CI build item to error if .shoov.yml is missing #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amitaibu Could you please review this PR? (screenshot is in the issue - #51 (comment)) |
| @@ -63,7 +63,8 @@ module.exports = function(config, logger) { | |||
| // Get Shoov configuration file from repository. | |||
| .then(function(response) { | |||
| if (!response) { | |||
| throw new Error("Can't get .shoov.yml"); | |||
| // Send other type of an error if file doesn't exist at all. | |||
| throw new ReferenceError("Can't get .shoov.yml"); | |||
There was a problem hiding this comment.
Lets extend Error with our own Error (e.g. BadRequestError).
| @@ -11,6 +11,18 @@ var debug = false; | |||
| var conf = {}; | |||
| var log = {}; | |||
|
|
|||
| /** | |||
| * Implements custom Error type "FileNotFoundError". Extends Error. | |||
There was a problem hiding this comment.
@amitaibu Not sure about Docs for this.
There was a problem hiding this comment.
Maybe Extends error object to indicate a missing .shoov.yml file.
| * Error message | ||
| */ | ||
| function FileNotFoundError(message) { | ||
| this.name = "FileNotFoundError"; |
|
@amitaibu Ready. |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#51