Update api context to match shopware administration #369
+43
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@akf-bw is attempting to deploy a commit to the Shopware Frontends Team on Vercel. A member of the Team first needs to authorize it. |
|
@seggewiss @jleifeld Could you please take a look at this? 💙 As soon as this PR has been merged & the package been updated, I like to open a new PR in the https://github.com/shopware/shopware repository to use the |
seggewiss
previously approved these changes
Nov 12, 2024
akf-bw
force-pushed
the
update-api-context
branch
from
1f92edb to
31768f4
Compare
|
@seggewiss @jleifeld Are there any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
ApiContexttype fromadmin-sdk/src/_internals/data/EntityCollection.tstoadmin-sdk/src/context/index.tsand also updates it with the missing fields of the shopware administration (language.parentId,currencyId&versionId)ApiContexttype inadmin-sdk/src/_internals/data/EntityCollection.tsWhy?
ApiContexttype in theEntityCollection& theContextState.apitype in the shopware administration mismatchHow?
ApiContexttype fromadmin-sdk/src/_internals/data/EntityCollection.tstoadmin-sdk/src/context/index.tsApiContexttype in theEntityCollection, but I've marked it asdeprecatedso it can be removed with a future updateAnything Else?
ApiContexttype from themeteor-admin-sdkpackage in theContext.apitype instead of the own defined type in the shopware administration